-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Redirects for drilldown links #83846
[DOCS] Redirects for drilldown links #83846
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checked that docLinks that we released with 7.10 will open /url-drilldown.html
which displayed "moved content" page.
There are issues with current docsLinks
(which are in master, 7.x, 7.10 branches) because subheading structure has changed. So some links won't point to proper page section. See below. I think it is fine to fix it in separate follow up pr.
@@ -33,7 +33,7 @@ you can create a drilldown that navigates from the overall status dashboard to a | |||
that shows a single data center or server. | |||
|
|||
[float] | |||
[[url-drilldown]] | |||
[[url-drilldowns]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L42
I think it is fine to fix docsLinks
in separate follow up pr to make current pr move faster through backports (to no trigger whole CI because of code changes) as it's anyway won't hurt 7.10 where we want to fix different problem.
Leaving this up to you if you'd like to make this change in current pr
@@ -137,7 +137,7 @@ Example: | |||
|
|||
|
|||
[float] | |||
[[variables]] | |||
[[url-template-variables]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means we also have to change: https://github.com/elastic/kibana/blob/master/src/core/public/doc_links/doc_links_service.ts#L44
I think it is fine to fix docsLinks
in separate follow up pr to make current pr move faster through backports (to no trigger whole CI because of code changes) as it's anyway won't hurt 7.10 where we want to fix different problem.
Leaving this up to you if you'd like to make this change in current pr
* Fixes lGo to URL links * Fixes links pt 2 * Added redirects * Added Lens and reformatted redirects * Removed lens and fixed broken links * Fixes to URL drilldowns link Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fixes lGo to URL links * Fixes links pt 2 * Added redirects * Added Lens and reformatted redirects * Removed lens and fixed broken links * Fixes to URL drilldowns link Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fixes lGo to URL links * Fixes links pt 2 * Added redirects * Added Lens and reformatted redirects * Removed lens and fixed broken links * Fixes to URL drilldowns link Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* master: (25 commits) [Alerting] fixes buggy default message behaviour (elastic#84202) [Graph] Use new ES client and change license API (elastic#84398) [DOCS] Adds redirect to known plugins page (elastic#84001) Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376) Adding timestamps to created events so the sorting is stable (elastic#84515) [DOCS] Redirects for drilldown links (elastic#83846) [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805) [Enterprise Search] Migrate shared Schema components (elastic#84381) [Discover] Unskip date_nanos and shard links functional tests (elastic#82878) [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) ...
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
* [DOCS] Redirects for drilldown links (#83846) * Fixes lGo to URL links * Fixes links pt 2 * Added redirects * Added Lens and reformatted redirects * Removed lens and fixed broken links * Fixes to URL drilldowns link Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Fixes whats new links Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #83268
Checklist