Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Enable check for org context based on URL #83487

Merged
merged 2 commits into from
Nov 17, 2020
Merged

[Workplace Search] Enable check for org context based on URL #83487

merged 2 commits into from
Nov 17, 2020

Conversation

scottybollinger
Copy link
Contributor

Summary

As a part of the Workplace Search migration to Kibana, we have to know in the Sources logic files whether the user is in an org context or in the personal dashboard. In the legacy ent-search app, we prefixed all organization routes with /org. It was decided that in Kibana, we'd switch the URL structure to have the prefix on non-org routes and use the /p prefix.

Before
Organization: http://localhost:3002/ws#/org/sources
Personal: http://localhost:3002/ws#/sources

After
Organization: http://localhost:5601/app/enterprise_search/workplace_search/sources
Personal: http://localhost:5601/app/enterprise_search/workplace_search/p/sources

Equivalent logic in ent-search

Checklist

@scottybollinger
Add regex check to determine whether url is org
f1cddbe 
As a part of the Kibana migration, we are switching the URL structure to put the prefix on the personal dashboard. In ent-search, org routes were prefixed with `/org`. In Kibana the prefix switches to non-org routes and they will be prefixed with`/p`
@scottybollinger
Add isOrganization boolean to logic
0ccb72c
@scottybollinger scottybollinger added Feature:Plugins v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 16, 2020
@scottybollinger scottybollinger requested review from a team and yakhinvadim November 16, 2020 21:01
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 683.6KB 684.0KB +463.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yakhinvadim
yakhinvadim approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@yakhinvadim yakhinvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scottybollinger scottybollinger merged commit e4516ee into elastic:master Nov 17, 2020
@scottybollinger scottybollinger deleted the scottybollinger/personal-route-check branch November 17, 2020 13:37
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 17, 2020
@gmmorris
Merge branch 'master' into alerts/action-groups-as-conditions
2985ee2 
* master: (51 commits)
  [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439)
  adds xpack.security.authc.selector.enabled setting (elastic#83551)
  skip flaky suite (elastic#77279)
  [ML] Improve support for script and aggregation fields in anomaly detection jobs (elastic#81923)
  [Workplace Search] Migrate SourcesLogic from ent-search (elastic#83544)
  [ML] Add UI test for feature importance features (elastic#82677)
  [Maps] Improve icons for all layer types (elastic#83503)
  Replace experimental badge with Beta (elastic#83468)
  [Fleet][EPM] Unified install and archive (elastic#83384)
  Move src/legacy/server/keystore to src/cli (elastic#83483)
  Used SO for saving the API key IDs that should be deleted (elastic#82211)
  [Uptime] Mock implementation to account for math flakiness test (elastic#83535)
  [Workplace Search] Enable check for org context based on URL (elastic#83487)
  [App Search] Added all Document related routes and logic (elastic#83324)
  [Alerting UI] Fix console error when setting connector params (elastic#83333)
  [Discover] Allow custom name for fields via index pattern field management (elastic#70039)
  [Uptime] Fix monitor list down histogram (elastic#83411)
  remove headers timeout hack, rely on nodejs timeouts (elastic#83419)
  [ML] Update console autocomplete for ML data frame evaluate API (elastic#83151)
  [Lens] Color in dimension trigger (elastic#76871)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 19, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83487 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83487 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83487 or prevent reminders by adding the backport:skip label.

@scottybollinger scottybollinger added the backport:skip This commit does not require backporting label Nov 23, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakhinvadim yakhinvadim yakhinvadim approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottybollinger @kibanamachine @yakhinvadim