Correctly sort Index Management data streams by storage size. #86204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrectly by storage size. They were previously being sorted alphabetically using the humanized size value. Now they're sorted numerically by the raw bytes value.
cjcenizal
added
release_note:fix
Feature:Index Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Code LGTM. Verified locally. Thanks for fixing this @cjcenizal!
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Dec 17, 2020
…rrectly by storage size. (elastic#86204) They were previously being sorted alphabetically using the humanized size value. Now they're sorted numerically by the raw bytes value.
cjcenizal
added a commit
that referenced
this pull request
Dec 18, 2020
…ed incorrectly by storage size. (#86204) (#86390) * Fix bug in which Index Management data streams were being sorted incorrectly by storage size. (#86204) They were previously being sorted alphabetically using the humanized size value. Now they're sorted numerically by the raw bytes value. # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/data_streams_tab.helpers.ts # x-pack/plugins/index_management/__jest__/client_integration/home/data_streams_tab.test.ts # x-pack/plugins/index_management/server/routes/api/data_streams/register_get_route.ts # x-pack/test/api_integration/apis/management/index_management/data_streams.ts * Fix get data stream API and eslint error.
cjcenizal
changed the title
cjcenizal
changed the title
💔 Build Failed
Failed CI Steps
Test FailuresX-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/add_actions·ts.detection engine api security and spaces enabled add_actions adding actions should be able to create a new webhook action and attach it to a ruleStandard OutStack TraceChrome UI Functional Tests.test/functional/apps/visualize/_vertical_bar_chart_nontimeindex·js.visualize app vertical bar chart with index without time filter vertical bar with multiple splits should show correct seriesStandard OutStack TraceX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/find·ts.alerting api integration security and spaces enabled Alerts alerts find superuser at space1 should handle find alert request appropriatelyStandard OutStack Traceand 20 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
cjcenizal
added
the
release_note:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86122
Release note
The list of data streams in Index Management previously sorted alphabetically using the humanized size value. This resulted in an incorrect sort order, for example sorting in ascending order would display a data stream sized at "1kb" before one sized at "5b". Now they're sorted numerically by the raw bytes value, which displays the sorted data streams in the correct order.
Screenshots
Original incorrect order:
Current correct order:
To test
You can create a data stream with a size in megabytes by following the instructions in the Index Management
READMEfor creating a data stream and then spamming the request for creating a document in Console by holding down Cmd+Enter. The Console history will be overwhelmed and you'll see a ton of error toasts but you can ignore those. After you create 800-1000 documents the data stream should be 1mb in size.