-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[esArchiver] upgrade to new ES client #89874
Merged
spalger
merged 10 commits into
elastic:master
from
spalger:upgrade/es-archiver-new-client
Feb 2, 2021
Merged
[esArchiver] upgrade to new ES client #89874
spalger
merged 10 commits into
elastic:master
from
spalger:upgrade/es-archiver-new-client
Feb 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.12.0
v8.0.0
labels
Feb 1, 2021
Pinging @elastic/kibana-operations (Team:Operations) |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/feature_controls/monitoring_security·ts.Monitoring app feature controls security "before all" hook in "security"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/feature_controls/monitoring_security·ts.Monitoring app feature controls security "after all" hook in "security"Standard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Feb 2, 2021
spalger
added a commit
that referenced
this pull request
Feb 3, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereq of #89805
Migrate the ES Archiver to the new
@elastic/elasticsearch
client, which brings some subtle API changes (like wrapping the response body in a.body
property) and some welcome helpers for scrolling through documents and bulk indexing which automatically retries on failures.By moving to these new helpers there were two test files that had to be rewritten, as they were testing the implementation details which are now handled by
@elastic/elasticsearch
.This should make it trivial for us to add additional HTTP headers to specific operations as required by #89805.