Unskip Search Sessions Management UI test #90110

tsullivan · 2021-02-03T00:47:47Z

Summary

tsullivan · 2021-02-03T18:58:23Z

tsullivan · 2021-02-04T02:14:11Z

13:36:33               └-> Cancels a session from management
13:36:33                 └-> "before each" hook: global before each
13:36:35                 │ERROR browser[SEVERE] http://localhost:61241/40129/bundles/core/core.entry.js 12:158432 TypeError: Failed to fetch
13:36:35                 │          at fetch_Fetch.fetchResponse (http://localhost:61241/40129/bundles/core/core.entry.js:6:32451)
13:36:35                 │          at async interceptResponse (http://localhost:61241/40129/bundles/core/core.entry.js:6:28637)
13:36:35                 │          at async http://localhost:61241/40129/bundles/core/core.entry.js:6:31117
13:42:41                 └- ✖ fail: search sessions management Search sessions Management UI New search sessions Cancels a session from management
13:42:41                 │      Error: Timeout of 360000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/dev/shm/workspace/parallel/24/kibana/x-pack/test/send_search_to_background_integration/tests/apps/management/search_sessions/sessions_management.ts)
13:42:41                 │       at listOnTimeout (internal/timers.js:554:17)
13:42:41                 │       at processTimers (internal/timers.js:497:7)
13:42:41                 │ 
13:42:41                 │ 
13:42:41               └-> "after all" hook
13:42:41               └-> "after all" hook
13:42:41                 │ proc [kibana]   log   [20:42:34.550] [warning][environment] Detected an unhandled Promise rejection.
13:42:41                 │ proc [kibana] Error: resource_not_found_exception
13:42:41             └-> "after all" hook
13:42:41           └-> "after all" hook
13:42:41       │
13:42:41       │15 passing (16.0m)
13:42:41       │1 failing
13:42:41       │
13:42:41       │1)    search sessions management
13:42:41       │       Search sessions Management UI
13:42:41       │         New search sessions
13:42:41       │           Cancels a session from management:
13:42:41       │
13:42:41       │      Error: Timeout of 360000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/dev/shm/workspace/parallel/24/kibana/x-pack/test/send_search_to_background_integration/tests/apps/management/search_sessions/sessions_management.ts)
13:42:41       │       at listOnTimeout (internal/timers.js:554:17)
13:42:41       │       at processTimers (internal/timers.js:497:7)
13:42:41       │ 
13:42:41       │ 
13:42:41       │
13:42:41       │ debg TestSubjects.find(searchSessionsMgmtTable)
13:42:41       │ debg Find.findByCssSelector('[data-test-subj="searchSessionsMgmtTable"]') with timeout=10000
13:42:41       │ debg Sending "SIGTERM" to proc "kibana"

tsullivan · 2021-02-04T16:14:03Z

Need to await a promise in: https://github.com/elastic/kibana/pull/87966/files#diff-6ed2e0e44f6b08e16d11662deb4577612c758ae4b24e283c8f94d4566b67d2b6R321

tsullivan · 2021-02-05T23:51:26Z

@elasticmachine merge upstream

tsullivan · 2021-02-09T17:04:47Z

@elasticmachine merge upstream

lizozom · 2021-02-13T08:45:46Z

@elasticmachine merge upstream

tsullivan · 2021-02-16T04:30:49Z

@elasticmachine merge upstream

tsullivan · 2021-02-17T22:27:43Z

...earch_to_background_integration/tests/apps/management/search_sessions/sessions_management.ts

+        await esArchiver.unload('data/search_sessions');
+      });
+
+      it('has working pagination controls', async () => {


Bonus: new test!

tsullivan · 2021-02-17T22:29:11Z

...earch_to_background_integration/tests/apps/management/search_sessions/sessions_management.ts

@@ -73,7 +77,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
      });

      // NOTE: this test depends on the previous one passing
-      it('Reloads as new session from management', async () => {
+      it.skip('Reloads as new session from management', async () => {


I'm not sure how this test is supposed to pass. I think the UI changed while the suite was skipped, and the test is obsolete now.

cc @Dosant

@tsullivan we removed the "reload" button in #90015 so this test case could be removed

tsullivan · 2021-02-17T22:34:44Z

Tests pass locally now. The problems were:

The Search Session background task document must in es_archive data for tests that rely on having the background task run
The es_archive data for testing the Management UI needed to have the username field match test_user (and realmName / realmType also had to match) since the listing is filtered by user

tsullivan · 2021-02-18T22:02:52Z

@elasticmachine merge upstream

tsullivan · 2021-02-19T04:18:36Z

@elasticmachine merge upstream

kibanamachine · 2021-02-19T06:37:31Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataEnhanced`	161.5KB	161.5KB	-21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dataEnhanced`	40.2KB	40.4KB	+152.0B

History

💚 Build #107903 succeeded a41946c
💚 Build #107887 succeeded a41946c
💔 Build #107861 failed 09ca91f
💚 Build #107769 succeeded 4b01fc2
💔 Build #107577 failed 780bbfe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant

lgtm!

Dosant · 2021-02-19T11:23:44Z

...earch_to_background_integration/tests/apps/management/search_sessions/sessions_management.ts

    describe('New search sessions', () => {
      before(async () => {
        await PageObjects.common.navigateToApp('dashboard');
        log.debug('wait for dashboard landing page');
-        retry.tryForTime(10000, async () => {
+        await retry.tryForTime(10000, async () => {


* Unskip Search Sessions Management UI test * more logging * logging * ci test * skip reload test * add tm task to archives used by dependent tests * --wip-- [skip ci] * revert jest affecting changes * fix search sessions archive * add pagination test * test organize * log cleanup * fix async in tests * remove obsolete test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Unskip Search Sessions Management UI test * more logging * logging * ci test * skip reload test * add tm task to archives used by dependent tests * --wip-- [skip ci] * revert jest affecting changes * fix search sessions archive * add pagination test * test organize * log cleanup * fix async in tests * remove obsolete test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…ndition-for-hiding-recommded-allocation * 'master' of github.com:elastic/kibana: (117 commits) [coverage] ingest data in parallel (elastic#92074) [Lens] Drag and drop performance improvements (elastic#91641) A few more environment uiFilters fixes (elastic#92044) Enabling Uptime and Dashboard a11y test (elastic#91017) [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041) [Security Solution] [Detections] add overflow-wrap for description (elastic#91945) [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952) Skip flaky apm test elastic#91673 (elastic#92065) [docker] Default server.name to hostname (elastic#90799) Use documentation link service for snapshot restore (elastic#91596) [Security Solution] Clearing up all jest errors and warnings (elastic#91740) Add `@kbn/analytics` to UI Shared Deps (elastic#91810) [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920) [Security Solution] Adds cypress-pipe (elastic#91550) [ML] Fix event rate chart annotation position (elastic#91899) [APM] Break down error table api removing the sparklines (elastic#89138) docs: update dependencies table bug (elastic#91964) [Time to Visualize] Stay in Edit Mode After Dashboard Quicksave (elastic#91729) Unskip Search Sessions Management UI test (elastic#90110) [Fleet] Handle long text in agent details page (elastic#91776) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx # x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx

tsullivan added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0 labels Feb 3, 2021

tsullivan requested a review from a team as a code owner February 9, 2021 19:33

tsullivan added 7 commits February 16, 2021 23:23

Unskip Search Sessions Management UI test

d6c6f0f

more logging

360f77a

logging

06eeddb

ci test

0953cf1

skip reload test

40e7197

add tm task to archives used by dependent tests

3dc28ff

--wip-- [skip ci]

9615ee9

tsullivan force-pushed the flaky/search-sessions-2 branch from 99f0365 to 9615ee9 Compare February 17, 2021 06:28

tsullivan added 2 commits February 17, 2021 10:34

revert jest affecting changes

6e0dd7b

fix search sessions archive

8e611e1

tsullivan force-pushed the flaky/search-sessions-2 branch from e079807 to 8e611e1 Compare February 17, 2021 22:13

add pagination test

27c1488

tsullivan commented Feb 17, 2021

View reviewed changes

tsullivan added 3 commits February 17, 2021 17:59

Merge branch 'master' into flaky/search-sessions-2

5dd3e14

test organize

780bbfe

log cleanup

7cb8324

fix async in tests

4b01fc2

kibanamachine and others added 3 commits February 18, 2021 17:02

Merge branch 'master' into flaky/search-sessions-2

09ca91f

Merge branch 'master' into flaky/search-sessions-2

2990bee

remove obsolete test

a41946c

tsullivan force-pushed the flaky/search-sessions-2 branch from ba6fab1 to a41946c Compare February 19, 2021 04:20

Merge branch 'master' into flaky/search-sessions-2

fc9bd05

Dosant approved these changes Feb 19, 2021

View reviewed changes

tsullivan merged commit d31119c into elastic:master Feb 19, 2021

tsullivan deleted the flaky/search-sessions-2 branch February 19, 2021 17:28

This was referenced Feb 19, 2021

[7.x] Unskip Search Sessions Management UI test (#90110) #92050

Merged

[7.12] Unskip Search Sessions Management UI test (#90110) #92051

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unskip Search Sessions Management UI test #90110

Unskip Search Sessions Management UI test #90110

tsullivan commented Feb 3, 2021

tsullivan commented Feb 3, 2021

tsullivan commented Feb 4, 2021

tsullivan commented Feb 4, 2021

tsullivan commented Feb 5, 2021

tsullivan commented Feb 9, 2021

lizozom commented Feb 13, 2021

tsullivan commented Feb 16, 2021

tsullivan Feb 17, 2021

tsullivan Feb 17, 2021

Dosant Feb 18, 2021

tsullivan commented Feb 17, 2021

tsullivan commented Feb 18, 2021

tsullivan commented Feb 19, 2021

kibanamachine commented Feb 19, 2021

Dosant left a comment

Dosant Feb 19, 2021

Unskip Search Sessions Management UI test #90110

Unskip Search Sessions Management UI test #90110

Conversation

tsullivan commented Feb 3, 2021

Summary

tsullivan commented Feb 3, 2021

tsullivan commented Feb 4, 2021

tsullivan commented Feb 4, 2021

tsullivan commented Feb 5, 2021

tsullivan commented Feb 9, 2021

lizozom commented Feb 13, 2021

tsullivan commented Feb 16, 2021

tsullivan Feb 17, 2021

Choose a reason for hiding this comment

tsullivan Feb 17, 2021

Choose a reason for hiding this comment

Dosant Feb 18, 2021

Choose a reason for hiding this comment

tsullivan commented Feb 17, 2021

tsullivan commented Feb 18, 2021

tsullivan commented Feb 19, 2021

kibanamachine commented Feb 19, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Dosant left a comment

Choose a reason for hiding this comment

Dosant Feb 19, 2021

Choose a reason for hiding this comment