Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Detections] add overflow-wrap for description #91945

Merged
merged 2 commits into from
Feb 19, 2021
Merged

[Security Solution] [Detections] add overflow-wrap for description #91945

merged 2 commits into from
Feb 19, 2021

Conversation

dhurley14
Copy link
Contributor

@dhurley14 dhurley14 commented Feb 18, 2021 •
edited
Loading

Summary

fixes: #90262

fixed_overflow_text_rule_desc

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dhurley14 dhurley14 self-assigned this Feb 18, 2021
@dhurley14
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.7MB 7.7MB +23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

@dhurley14 dhurley14 changed the title [DRAFT] [Security Solution] [Detections] add overflow-wrap for description [Security Solution] [Detections] add overflow-wrap for description Feb 19, 2021
@dhurley14 dhurley14 marked this pull request as ready for review February 19, 2021 17:42
@dhurley14 dhurley14 requested a review from a team as a code owner February 19, 2021 17:42
@dhurley14 dhurley14 added Feature:Detection Rules Anything related to Security Solution's Detection Rules review Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team v7.11.2 v7.12.0 v8.0.0 labels Feb 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@dhurley14 dhurley14 added release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 19, 2021
ecezalp
ecezalp approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@ecezalp ecezalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was able to visually verify the fix. approved

Screen Shot 2021-02-19 at 3 13 37 PM

@dhurley14 dhurley14 merged commit 52c4dec into elastic:master Feb 19, 2021
@dhurley14 dhurley14 deleted the long-text-overflow-issue branch February 19, 2021 22:56
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2021
@dhurley14 @kibanamachine
[Security Solution] [Detections] add overflow-wrap for description (e…
171d1b6 
…lastic#91945)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Feb 19, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2021
@dhurley14 @kibanamachine
[Security Solution] [Detections] add overflow-wrap for description (e…
1d9cd1d 
…lastic#91945)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Feb 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.11 / #92097
✅ 7.12 / #92098

Successful backport PRs will be merged automatically after passing CI.

@dhurley14 dhurley14 mentioned this pull request Feb 19, 2021
Merged
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Feb 19, 2021
@dhurley14 @kibanamachine
[Security Solution] [Detections] add overflow-wrap for description (e…
e3a6115 
…lastic#91945)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 20, 2021
@kibanamachine @dhurley14
[Security Solution] [Detections] add overflow-wrap for description (#…
866babd 
…91945) (#92097)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 20, 2021
@kibanamachine @dhurley14
[Security Solution] [Detections] add overflow-wrap for description (#…
7290945 
…91945) (#92098)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
dhurley14 added a commit that referenced this pull request Feb 20, 2021
@dhurley14 @kibanamachine
[Security Solution] [Detections] add overflow-wrap for description (#…
970938c 
…91945) (#92103)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 22, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/update-co…
b4d6ef5 
…ndition-for-hiding-recommded-allocation

* 'master' of github.com:elastic/kibana: (117 commits)
  [coverage] ingest data in parallel (elastic#92074)
  [Lens] Drag and drop performance improvements (elastic#91641)
  A few more environment uiFilters fixes (elastic#92044)
  Enabling Uptime and Dashboard a11y test (elastic#91017)
  [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041)
  [Security Solution] [Detections] add overflow-wrap for description (elastic#91945)
  [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952)
  Skip flaky apm test elastic#91673 (elastic#92065)
  [docker] Default server.name to hostname (elastic#90799)
  Use documentation link service for snapshot restore (elastic#91596)
  [Security Solution] Clearing up all jest errors and warnings (elastic#91740)
  Add `@kbn/analytics` to UI Shared Deps (elastic#91810)
  [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920)
  [Security Solution] Adds cypress-pipe (elastic#91550)
  [ML] Fix event rate chart annotation position (elastic#91899)
  [APM] Break down error table api removing the sparklines (elastic#89138)
  docs: update dependencies table bug (elastic#91964)
  [Time to Visualize] Stay in Edit Mode After Dashboard Quicksave (elastic#91729)
  Unskip Search Sessions Management UI test (elastic#90110)
  [Fleet] Handle long text in agent details page (elastic#91776)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx
#	x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 22, 2021
@gmmorris
Merge branch 'task-manager/docs-monitoring' of github.com:gmmorris/ki…
f3d2e70 
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (29 commits)
  Update docs/developer/plugin-list.asciidoc
  Update docs/api/task-manager/health.asciidoc
  Update docs/api/task-manager/health.asciidoc
  [Lens] Load indexpatterns list from indexPattern Service (elastic#91984)
  [coverage] ingest data in parallel (elastic#92074)
  [Lens] Drag and drop performance improvements (elastic#91641)
  A few more environment uiFilters fixes (elastic#92044)
  Enabling Uptime and Dashboard a11y test (elastic#91017)
  [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041)
  [Security Solution] [Detections] add overflow-wrap for description (elastic#91945)
  [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952)
  Skip flaky apm test elastic#91673 (elastic#92065)
  [docker] Default server.name to hostname (elastic#90799)
  Use documentation link service for snapshot restore (elastic#91596)
  [Security Solution] Clearing up all jest errors and warnings (elastic#91740)
  Add `@kbn/analytics` to UI Shared Deps (elastic#91810)
  [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920)
  [Security Solution] Adds cypress-pipe (elastic#91550)
  [ML] Fix event rate chart annotation position (elastic#91899)
  [APM] Break down error table api removing the sparklines (elastic#89138)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 22, 2021
@gmmorris
Merge branch 'master' into alerting/onclose-indicator
ce20d1c 
* master: (36 commits)
  [Uptime] Thumbnail full screen view steps navigation fix (elastic#91895)
  Implement ScopedHistory.block (elastic#91099)
  [Lens] Fix overlowing content on a chart for charts and table (elastic#92006)
  handle source column differences in embeddable as well (elastic#91987)
  [Vega] [Map] disable map rotation using right right click /  touch rotation gesture (elastic#91996)
  [Lens] Load indexpatterns list from indexPattern Service (elastic#91984)
  [coverage] ingest data in parallel (elastic#92074)
  [Lens] Drag and drop performance improvements (elastic#91641)
  A few more environment uiFilters fixes (elastic#92044)
  Enabling Uptime and Dashboard a11y test (elastic#91017)
  [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041)
  [Security Solution] [Detections] add overflow-wrap for description (elastic#91945)
  [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952)
  Skip flaky apm test elastic#91673 (elastic#92065)
  [docker] Default server.name to hostname (elastic#90799)
  Use documentation link service for snapshot restore (elastic#91596)
  [Security Solution] Clearing up all jest errors and warnings (elastic#91740)
  Add `@kbn/analytics` to UI Shared Deps (elastic#91810)
  [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920)
  [Security Solution] Adds cypress-pipe (elastic#91550)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecezalp ecezalp ecezalp approved these changes

@dplumlee dplumlee dplumlee approved these changes

Assignees

@dhurley14 dhurley14

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:fix review Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.2 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Text overflow issue for long EQL queries in Rule Details page Definition section
5 participants
@dhurley14 @kibanamachine @elasticmachine @ecezalp @dplumlee