Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vega] [Map] disable map rotation using right right click / touch rotation gesture #91996

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 19, 2021

Summary

Regression after migration Leaflet -> MapBox. We should disable map rotation using right right click / touch rotation gesture cause this type of interaction doesn't supported by Vega projections.

Steps to reproduce:

  1. Open [Flights] Airport Connections (Hover Over Airport) sample data.
  2. Be sure that you have some data on your visualization
  3. Press right button and move map
Screen.Recording.2021-02-19.at.3.08.29.PM.mov

@alexwizp alexwizp self-assigned this Feb 19, 2021
@alexwizp alexwizp added v7.12.0 v7.13.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes and removed v7.13.0 labels Feb 19, 2021
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanx for noticing this Aliaksei :)

@alexwizp alexwizp marked this pull request as ready for review February 19, 2021 14:06
@alexwizp alexwizp requested a review from a team February 19, 2021 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, good catch

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 2.7MB 2.7MB +84.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@alexwizp alexwizp merged commit 5fa9370 into elastic:master Feb 22, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 22, 2021
…ation gesture (elastic#91996)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 22, 2021
…ation gesture (elastic#91996)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 22, 2021
* master: (36 commits)
  [Uptime] Thumbnail full screen view steps navigation fix (elastic#91895)
  Implement ScopedHistory.block (elastic#91099)
  [Lens] Fix overlowing content on a chart for charts and table (elastic#92006)
  handle source column differences in embeddable as well (elastic#91987)
  [Vega] [Map] disable map rotation using right right click /  touch rotation gesture (elastic#91996)
  [Lens] Load indexpatterns list from indexPattern Service (elastic#91984)
  [coverage] ingest data in parallel (elastic#92074)
  [Lens] Drag and drop performance improvements (elastic#91641)
  A few more environment uiFilters fixes (elastic#92044)
  Enabling Uptime and Dashboard a11y test (elastic#91017)
  [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041)
  [Security Solution] [Detections] add overflow-wrap for description (elastic#91945)
  [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952)
  Skip flaky apm test elastic#91673 (elastic#92065)
  [docker] Default server.name to hostname (elastic#90799)
  Use documentation link service for snapshot restore (elastic#91596)
  [Security Solution] Clearing up all jest errors and warnings (elastic#91740)
  Add `@kbn/analytics` to UI Shared Deps (elastic#91810)
  [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920)
  [Security Solution] Adds cypress-pipe (elastic#91550)
  ...
alexwizp added a commit that referenced this pull request Feb 23, 2021
…ation gesture (#91996) (#92138)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Feb 23, 2021
…ation gesture (#91996) (#92139)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants