-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Kibana & Elasticsearch logging config keys #90764
Conversation
@elasticmachine merge upstream |
b5c2b9c
to
4faf84e
Compare
4faf84e
to
00f786a
Compare
Pinging @elastic/kibana-core (Team:Core) |
This is a breaking change for ECS audit logging which was introduced in 7.11. Is there any reason we can't keep the old fields around and deprecate them? |
@jportner Is it already in GA as a stable feature? I can add a deprecation warning for the Security plugin. Would it work for you? |
Yes and yes, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. do we need to list the config changes here? #85858
@Bamieh We will when we deprecate the legacy logging config. The new logging config has never been announced yet in our docs nor release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security changes LGTM!
* align logging config with ES. rename kind to type. * rename file "path" to "fileName" * rename logger "context" to "name" * update audit log docs and tests * update docs * fix integration tests * update deprecations for audit appender * add tests for audit logging deprecations * fix eslint problem Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security/server/config_deprecations.ts
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Jest Integration Tests.src/core/server/saved_objects/migrationsv2/integration_tests.migration v2 migrating from the same Kibana version copies all the document of the previous index to the new oneStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Part of #57551
This PR align Kibana logging configuration keys with log4j and renames:
appender.kind
,layout.kind
,strategy.kind
,policy.kind
toappender.type
,layout.type
, etc.file-appender.path
tofile-appender.fileName
logger.xxx.context
tologger.xxx.name
Plugin API changes
Kibana logging system uses a configuration schema inspired by
log4j
to provide Elasticsearch-compatible format. We renamed several logging configuration keys to align the naming schema with the Elasticsearch config:*.kind
is renamed to*.type
file-appender.path
tofile-appender.fileName
logger.xxx.context
tologger.xxx.name