Fixes ECS audit logging config settings for docker environments #92497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jportner
commented
Feb 23, 2021
Comment on lines
+263
to
+275
| xpack.security.audit.appender.type | ||
| xpack.security.audit.appender.layout.type | ||
| xpack.security.audit.appender.layout.highlight | ||
| xpack.security.audit.appender.layout.pattern | ||
| xpack.security.audit.appender.legacyLoggingConfig | ||
| xpack.security.audit.appender.fileName | ||
| xpack.security.audit.appender.policy.type | ||
| xpack.security.audit.appender.policy.interval | ||
| xpack.security.audit.appender.policy.modulate | ||
| xpack.security.audit.appender.policy.size | ||
| xpack.security.audit.appender.strategy.type | ||
| xpack.security.audit.appender.strategy.max | ||
| xpack.security.audit.appender.strategy.pattern |
There was a problem hiding this comment.
Many of these keys changed in 7.12 via #90764 -- kind -> type, and path -> fileName.
Since we don't have anyone using these values in Docker yet, I think we should only support the new values, and we should not backport this PR to 7.11.
| xpack.security.audit.appender.strategy.type | ||
| xpack.security.audit.appender.strategy.max | ||
| xpack.security.audit.appender.strategy.pattern | ||
| xpack.security.audit.ignore_filters |
There was a problem hiding this comment.
The ignore_filters setting is an array. Users would configure .ignore_filters[].actions[], .ignore_filters[].categories[], etc. But I think that we shouldn't specify actions, categories`, etc. in the Docker kibana vars. Is that correct?
jbudz
approved these changes
Feb 23, 2021
jportner
added
the
auto-backport
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 23, 2021
This was referenced Feb 23, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 23, 2021
kibanamachine
added a commit
that referenced
this pull request
Feb 23, 2021
kibanamachine
added a commit
that referenced
this pull request
Feb 23, 2021
|
Pinging @elastic/kibana-operations (Team:Operations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #92046.