Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indexpattern management] Use indexPatterns Service instead of savedObjects client #91839

Merged

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 18, 2021

Summary

Part of #91715.

Replaces the savedObjects client with the indexpatterns service API in all places that it is required to retrieve the index patterns.

Checklist

@stratoula stratoula changed the title [Index pattern management] Use indexPatterns Service instead of saved… [Index pattern management] Use indexPatterns Service instead of savedObjects client Feb 18, 2021
@stratoula stratoula changed the title [Index pattern management] Use indexPatterns Service instead of savedObjects client [Indexpattern management] Use indexPatterns Service instead of savedObjects client Feb 18, 2021
@stratoula stratoula added Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 18, 2021
@stratoula stratoula marked this pull request as ready for review February 18, 2021 15:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested review from mattkime and a team February 18, 2021 15:55
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternManagement 565.1KB 564.9KB -256.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 494d1de into elastic:master Feb 19, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Feb 19, 2021
…bjects client (elastic#91839)

* [Index pattern management] Use indexPatterns Service instead of savedObjects client

* Minor fixes

* Keep the same test setup
stratoula added a commit that referenced this pull request Feb 19, 2021
…savedObjects client (#91839) (#91985)

* [Indexpattern management] Use indexPatterns Service instead of savedObjects client (#91839)

* [Index pattern management] Use indexPatterns Service instead of savedObjects client

* Minor fixes

* Keep the same test setup

* Fix ci problem

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 19, 2021
* master: (111 commits)
  [Logs UI] Replace dependencies in the infra bundle (elastic#91503)
  [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921)
  [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918)
  Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657)
  [Fleet] Don't error on missing package_assets value (elastic#91744)
  [Lens] Pass used histogram interval to chart (elastic#91370)
  [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839)
  [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947)
  [CI] backportrc can skip CI (elastic#91886)
  Revert "[SOM] fix flaky suites (elastic#91809)"
  [Fleet] Install Elastic Agent integration by default during setup (elastic#91676)
  [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778)
  [data.search] Use incrementCounter for search telemetry (elastic#91230)
  [Fleet] Bootstrap functional test suite (elastic#91898)
  [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067)
  Use correct environment in anomaly detection setup link (elastic#91877)
  [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770)
  [CI] Build and publish storybooks (elastic#87701)
  docs: add PHP agent info to docs (elastic#91773)
  [DOCS] Adds and updates Visualization advanced settings (elastic#91904)
  ...
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages and removed Feature:Index Management Index and index templates UI labels Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants