Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Kql Search Bar suggests values outside the selected time range #91918

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[APM] Kql Search Bar suggests values outside the selected time range #91918

merged 1 commit into from
Feb 19, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #90166

Screenshot 2021-02-18 at 14 07 38

Screenshot 2021-02-18 at 14 07 50

Screenshot 2021-02-18 at 14 08 01

Screenshot 2021-02-18 at 14 08 11

Screenshot 2021-02-18 at 14 08 43

@cauemarcondes cauemarcondes added release_note:fix v7.12.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 18, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner February 18, 2021 19:20
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

ogupte
ogupte approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@cauemarcondes cauemarcondes changed the title apm-kql-time-range-filter [APM] Kql Search Bar suggests values outside the selected time range Feb 18, 2021
@dgieselaar
Copy link
Member

dgieselaar commented Feb 18, 2021 •
edited
Loading

@cauemarcondes can you provide some information why this (timeFieldName) was necessary or why it broke?

@cauemarcondes
Copy link
Contributor Author

@cauemarcondes can you provide some information why this (timeFieldName) was necessary

Even though we set useTimeRange: true on the data plugin function autocomplete.getQuerySuggestions we still need to specify the field to the range filter. Without timeFieldName the range filter is never applied.

or why it broke?

It wasn't broken, it was only skipping the range filter to be added in the query.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 1fa742d into elastic:master Feb 19, 2021
@cauemarcondes cauemarcondes deleted the apm-kql-time-range-filter branch February 19, 2021 13:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2021
@cauemarcondes @kibanamachine
[APM] Kql Search Bar suggests values outside the selected time range (e…
ddc2f79 
…lastic#91918)
@kibanamachine kibanamachine mentioned this pull request Feb 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #92013

Successful backport PRs will be merged automatically after passing CI.

@cauemarcondes cauemarcondes mentioned this pull request Feb 19, 2021
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 19, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
fa807e9 
* master: (111 commits)
  [Logs UI] Replace dependencies in the infra bundle (elastic#91503)
  [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921)
  [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918)
  Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657)
  [Fleet] Don't error on missing package_assets value (elastic#91744)
  [Lens] Pass used histogram interval to chart (elastic#91370)
  [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839)
  [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947)
  [CI] backportrc can skip CI (elastic#91886)
  Revert "[SOM] fix flaky suites (elastic#91809)"
  [Fleet] Install Elastic Agent integration by default during setup (elastic#91676)
  [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778)
  [data.search] Use incrementCounter for search telemetry (elastic#91230)
  [Fleet] Bootstrap functional test suite (elastic#91898)
  [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067)
  Use correct environment in anomaly detection setup link (elastic#91877)
  [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770)
  [CI] Build and publish storybooks (elastic#87701)
  docs: add PHP agent info to docs (elastic#91773)
  [DOCS] Adds and updates Visualization advanced settings (elastic#91904)
  ...
kibanamachine added a commit that referenced this pull request Feb 19, 2021
@kibanamachine @cauemarcondes
[APM] Kql Search Bar suggests values outside the selected time range (#…
385242a 
…91918) (#92013)

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Feb 19, 2021
@cauemarcondes
[APM] Kql Search Bar suggests values outside the selected time range (#…
a2ee1b6 
…91918) (#92016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM All issues that need APM UI Team support v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Kql Search Bar suggests values outside the selected time range
6 participants
@cauemarcondes @elasticmachine @dgieselaar @kibanamachine @sorenlouv @ogupte