Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searchDuration to EQL and Threshold rules #93149

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

ecezalp
Copy link
Contributor

@ecezalp ecezalp commented Mar 1, 2021

Closes #82861.

Summary

This commit ensures that the Query Time column in the Rule Management table is filled for EQL and Threshold rules.

Checklist

Delete any items that are not applicable to this PR.

@ecezalp ecezalp requested a review from a team as a code owner March 1, 2021 23:08
@ecezalp ecezalp requested a review from rylnd March 1, 2021 23:08
@ecezalp ecezalp self-assigned this Mar 1, 2021
@ecezalp ecezalp added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Mar 1, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ecezalp

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair-tested this with @ecezalp, as the screenshots will show. LGTM!

@ecezalp
Copy link
Contributor Author

ecezalp commented Mar 2, 2021

before
image (16)

after
Screen Shot 2021-03-02 at 4 41 04 PM

@ecezalp ecezalp merged commit 819cb48 into elastic:master Mar 2, 2021
ecezalp added a commit to ecezalp/kibana that referenced this pull request Mar 2, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 3, 2021
* master: (45 commits)
  Add outcome of node scripts/build_api_docs (elastic#93399)
  [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279)
  [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224)
  [uptime] Fix anomaly alert edit (elastic#93025)
  Consolidate @babel/* packages and use latest compatible version (elastic#93264)
  [Search Embeddable] Add highlighting when searching (elastic#93178)
  [APM] Add missing bottom border to header (elastic#93179)
  [CI] No longer collect APM span stack traces (elastic#93263)
  [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024)
  update generated public api docs
  API DOCS Step 3/3 (elastic#92929)
  chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262)
  rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620)
  [kbn/optimizer] allow customizing the limits path from the script (elastic#93153)
  [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830)
  [jenkins] convert baseline capture job to use tasks (elastic#93288)
  removing the linked issue in comments from PR (elastic#93303)
  chore(NA): do not include fs within a storybook build (elastic#93294)
  [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156)
  Add searchDuration to EQL and Threshold rules (elastic#93149)
  ...
ecezalp added a commit to ecezalp/kibana that referenced this pull request Mar 3, 2021
@ecezalp ecezalp deleted the query-time branch March 3, 2021 15:40
Copy link
Contributor

@madirey madirey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] "Query Time" is not populated in Rules table for EQL or Threshold Rules
6 participants