-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NA): do not include fs module within a storybook build #93294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
Team label for Operations Team
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.13.0
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.12.1
labels
Mar 2, 2021
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
changed the title
chore(NA): do not include fs module within a storybook build
fix(NA): do not include fs module within a storybook build
Mar 2, 2021
spalger
approved these changes
Mar 2, 2021
jbudz
approved these changes
Mar 2, 2021
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/visualize/_heatmap_chart·ts.visualize app heatmap chart should show 6 color ranges if changed on optionsStandard Out
Stack Trace
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 2, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 2, 2021
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2021
smith
added a commit
to smith/kibana
that referenced
this pull request
Mar 3, 2021
Changes to fix APM's Storybook setup were made in elastic#93087 and elastic#93294. This re-enables it and fixes a couple places where we weren't using a theme provider.
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2021
* master: (45 commits) Add outcome of node scripts/build_api_docs (elastic#93399) [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279) [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224) [uptime] Fix anomaly alert edit (elastic#93025) Consolidate @babel/* packages and use latest compatible version (elastic#93264) [Search Embeddable] Add highlighting when searching (elastic#93178) [APM] Add missing bottom border to header (elastic#93179) [CI] No longer collect APM span stack traces (elastic#93263) [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024) update generated public api docs API DOCS Step 3/3 (elastic#92929) chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262) rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620) [kbn/optimizer] allow customizing the limits path from the script (elastic#93153) [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830) [jenkins] convert baseline capture job to use tasks (elastic#93288) removing the linked issue in comments from PR (elastic#93303) chore(NA): do not include fs within a storybook build (elastic#93294) [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156) Add searchDuration to EQL and Threshold rules (elastic#93149) ...
smith
added a commit
that referenced
this pull request
Mar 8, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 8, 2021
Changes to fix APM's Storybook setup were made in elastic#93087 and elastic#93294. This re-enables it and fixes a couple places where we weren't using a theme provider.
kibanamachine
added a commit
that referenced
this pull request
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.12.1
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes a problem @smith found when running
yarn storybook apm
by setting the fs module toempty
during the webpack compilation of a storybook.