[x-pack/build] exclude plugins/*/target when copying source to build #99009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
reproduce-failure--96111
branch
2 times, most recently
from
d74a0d9 to
fe08155
Compare
spalger
force-pushed
the
reproduce-failure--96111
branch
from
1e4438b to
f495af8
Compare
spalger
changed the title
spalger
added
release_note:skip
|
Reproducing this using the baseline Jenkinsfile and #96111 merged was an important part of verifying this works, that Jenkins build can be seen here: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/123860/ |
spalger
changed the title
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
May 3, 2021
spalger
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2021
…lastic#99009) Co-authored-by: spalger <spalger@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2021
…lastic#99009) Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #99005
Currently we are including the
plugins/*/target/typesdirectory in the distributable when it exists, which is only whennode scripts/build_ts_refsis executed (so it doesn't end up in our final distributable, or in the builds made in PRs). These directories do exist in the distributables created as part of the baseline jobs though, which was leading to file-length-check failures once #96111 was merged. With this change the baseline job and PR job should create the same distributable. Fixing the rest of #99005 will help us ensure that by reporting the changed files on all PRs so that something like this will be more obvious in the future.