Add JavaVersionChecker to check Java version for compatibility before… #13356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… running Provides a "friendly" error message when running Logstash with an incompatible version of Java
Improve readability of `JavaVersion` Fix logstash bash script to exit on JavaVersionChecker error
|
Note: This has been tested on MacOs and Windows |
jsvd
approved these changes
Oct 26, 2021
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Oct 26, 2021
…y before… (elastic#13356)" This reverts commit 620a654.
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Dec 16, 2021
… running Provides a "friendly" error message when running Logstash with an incompatible version of Java Readded version of elastic#13356, incorporated with use of Comparable from elastic#13358
3 tasks
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Jan 10, 2022
…n for compatibility before running Backport PR#13433 to 8.0 branch. Original message: Provides a "friendly" error message when running Logstash with an incompatible version of Java Readded from elastic#13356, incorporated with use of Comparable from elastic#13358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… running
This commit provides a "friendly" error message when running Logstash with an incompatible version of Java, printing the following error message when attempting to start logstash:
"the minimum required Java version is 11; your Java version from [%s] does not meet this requirement",This will prevent Logstash from running when at attempt is made to run using an older version of Logstash than java 11, which is the minimum requirement for Logstash
8.0