Add JavaVersionChecker to check Java version for compatibility before… #13533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… running Provides a "friendly" error message when running Logstash with an incompatible version of Java Readded version of elastic#13356, incorporated with use of Comparable from elastic#13358
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… running
Provides a "friendly" error message when running Logstash with an incompatible
version of Java
Readded version of #13356, incorporated with use of Comparable from #13358
Release notes
This commit prevents Logstash from attempting to start with a version of the JDK below Java 11, rather than logging a warning and crashing
What does this PR do?
This commit prevents Logstash from attempting to start with a version of the JDK below Java 11, rather than logging a warning and crashing
Why is it important/What is the impact to the user?
Later versions of
7.xwould provide a runtime warning/deprecation log when Logstash is run using JDK < 11, which will not be supported in Logstash 8 due to the changes to support nanosecond precision timestamps introduced in #12797. This commit will prevent Logstash from starting at all if JDK < 11 is used, presenting an error message to the user when this is attempted.Checklist
- [ ] I have made corresponding change to the default configuration files (and/or docker env variables)- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Pull down the latest version of Logstash, attempt to run using JDK8, 11, 17. Also test
bin/logstash-pluginfor correctnessRelated issues