Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all integration tests to new infrastructure #975

Closed
5 tasks done
danielmitterdorfer opened this issue Apr 27, 2020 · 2 comments
Closed
5 tasks done

Migrate all integration tests to new infrastructure #975

danielmitterdorfer opened this issue Apr 27, 2020 · 2 comments
Labels
enhancement Improves the status quo meta A high-level issue of a larger topic which requires more fine-grained issues / PRs :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Milestone

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Apr 27, 2020

In #919 we added a new integration test infrastructure based on py.test to replace the existing shell script integration-test.sh. While some of the integration tests have already been migrated, a couple of them are still left:

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo help wanted We'd be happy about a community contribution meta A high-level issue of a larger topic which requires more fine-grained issues / PRs :misc Changes that don't affect users directly: linter fixes, test improvements, etc. good first issue Small, contained changes that are good for newcomers labels Apr 27, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Apr 27, 2020
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.5.0, 1.6.0 Apr 29, 2020
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Apr 29, 2020
With this commit we migrate the integration test that checks for
misspelled track parameters to the new infrastructure.

Relates elastic#975
danielmitterdorfer added a commit that referenced this issue Apr 30, 2020
With this commit we migrate the integration test that checks for
misspelled track parameters to the new infrastructure.

Relates #975
hub-cap added a commit to hub-cap/rally that referenced this issue Jun 29, 2020
This commit moves the test_configure which validates the configure
command completes properly to the new infrastructure.

Relates elastic#975
hub-cap added a commit to hub-cap/rally that referenced this issue Jun 29, 2020
This commit moves the test_configure which validates the configure
command completes properly to the new infrastructure.

Relates elastic#975
@bartier
Copy link
Contributor

bartier commented Jul 15, 2020

@danielmitterdorfer Can I try to migrate the test_docker_dev_image tests? I did some tests with the first one and it apparently worked as it should. (BTW, it I'm not sure if it is the right way to do it, but I tried to follow the other tests migrations as a guideline as much as I could).

@danielmitterdorfer
Copy link
Member Author

@bartier sure, thanks for helping out. I think it would be good to get a preliminary review on the migration of the first test and then expand to further tests (in the same PR).

@danielmitterdorfer danielmitterdorfer removed good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution labels Jul 20, 2020
danielmitterdorfer added a commit that referenced this issue Jul 30, 2020
With this commit we migrate the integration test for HTTP proxy connections to
the new integration test infrastructure and cleanup any remaining leftovers in
the old script (which is still used for Docker release image tests).

Relates #975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo meta A high-level issue of a larger topic which requires more fine-grained issues / PRs :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

No branches or pull requests

2 participants