Migrate track param check to new IT infrastructure #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we migrate the integration test that checks for misspelled track parameters to the new infrastructure. Relates elastic#975
danielmitterdorfer
added
enhancement
|
|
||
|
|
||
| @it.random_rally_config | ||
| @it.rally_in_mem |
There was a problem hiding this comment.
I opted to switch all of these tests to the in-memory configuration because it does not matter at all which metrics store implementation we use here.
5 tasks
ebadyano
reviewed
Apr 29, 2020
| fi | ||
| restore_rally_log | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we also remove the call test_distribution_fails_with_wrong_track_params at line 457? https://github.com/elastic/rally/pull/977/files#diff-4799edc37363079fc48a459bce59b8f9R457
There was a problem hiding this comment.
Good catch! We should indeed. I've pushed a fix in 76b1ebf.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we migrate the integration test that checks for
misspelled track parameters to the new infrastructure.
Relates #975