Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Doc+) SIEM + frozen tier compatibility #5564

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

stefnestor
Copy link
Contributor

@stefnestor stefnestor commented Jul 15, 2024

👋🏽 howdy, team!

  1. Since ES Data Tiers are sequentially hardware performant, because we call out cold this appends the same rules apply to frozen (related to securitySolution:excludeColdAndFrozenTiersInAnalyzer from kibana#172162). Kindly see examples
    • kibana#139969 for linked internal examples of e.g. alert indices .alerts-security* being hosted in frozen breaking SIEM.
    • kb#39606517 where frozen indices containing future dates catch in the Rule lookback window and therefore can degrade product performance.
  2. It looks like there's a duplicate section in the SIEM and Kibana docs from security-docs#487 and kibana#103151, respectively, where the latter had additional phrasing so cross-pollinated.
    • ( Paper-trail FYI for my team: security-docs#551 later appears to confirm indicator rules don't support cold, to confirm between PR's which is latest state in (2). It does also suggest indicator match rules do not support cross cluster search, but that was purposely later removed in security-docs#3054 for v8.7 . )

Preview:

@stefnestor stefnestor requested a review from a team as a code owner July 15, 2024 21:03
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Jul 15, 2024

This pull request does not have a backport label. Could you fix it @stefnestor? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes, @stefnestor! Couple of questions, in addition to the comments that I left:

  • Do these changes need to be reflected in the Serverless version of this page too? If so, I'm happy to add those updates to this PR.
  • How far back should we port these changes? For example, is this information relevant to 8.7 - 8.15?

Thanks again for your help with keeping the Security docs current and correct!

docs/detections/detection-engine-intro.asciidoc Outdated Show resolved Hide resolved
docs/detections/detection-engine-intro.asciidoc Outdated Show resolved Hide resolved
docs/detections/detection-engine-intro.asciidoc Outdated Show resolved Hide resolved
stefnestor and others added 2 commits August 5, 2024 14:31
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@stefnestor
Copy link
Contributor Author

stefnestor commented Aug 5, 2024

Okay, ready again! 🙏

@nastasha-solomon nastasha-solomon merged commit 9d06354 into elastic:main Aug 9, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Aug 9, 2024
* (Doc+) Frozen tier compatibility

* feedback

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>

* feedback p2

* Update docs/detections/detection-engine-intro.asciidoc

* feedback

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 9d06354)
mergify bot pushed a commit that referenced this pull request Aug 9, 2024
* (Doc+) Frozen tier compatibility

* feedback

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>

* feedback p2

* Update docs/detections/detection-engine-intro.asciidoc

* feedback

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 9d06354)
nastasha-solomon pushed a commit that referenced this pull request Aug 13, 2024
* (Doc+) Frozen tier compatibility

* feedback

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>

* feedback p2

* Update docs/detections/detection-engine-intro.asciidoc

* feedback

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 9d06354)

Co-authored-by: Stef Nestor <26751266+stefnestor@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Aug 13, 2024
* (Doc+) Frozen tier compatibility

* feedback

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>

* feedback p2

* Update docs/detections/detection-engine-intro.asciidoc

* feedback

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 9d06354)

Co-authored-by: Stef Nestor <26751266+stefnestor@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants