Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to the latest playwright #485

Merged
merged 3 commits into from
Apr 1, 2022
Merged

fix: update to the latest playwright #485

merged 3 commits into from
Apr 1, 2022

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Apr 1, 2022 •
edited
Loading

  • fix Update PW to the latest version #484
  • We are keeping the formatter code in the Synthetics repo as it was easy to extend it from the Playwright core. Recorder will stay in the pinned version of synthetics for now and will be updated once the forked version changes.

@apmmachine
Copy link

apmmachine commented Apr 1, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-01T19:47:02.932+0000

  • Duration: 14 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 149
Skipped 2
Total 151

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

andrewvc
andrewvc approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test suite runs well and runs correctly with Elasticsearch. Nice work!

@andrewvc andrewvc mentioned this pull request Apr 1, 2022
Closed
vigneshshanmugam
vigneshshanmugam commented Apr 1, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@vigneshshanmugam vigneshshanmugam merged commit c05ccfe into elastic:main Apr 1, 2022
@vigneshshanmugam vigneshshanmugam deleted the update-pw-latest branch April 1, 2022 20:02
@vigneshshanmugam vigneshshanmugam mentioned this pull request Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update PW to the latest version
3 participants
@vigneshshanmugam @apmmachine @andrewvc