feat: update new synthetics test node locations #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vigneshshanmugam
commented
Jun 1, 2022
•
vigneshshanmugam
commented
- Part of Push command final touchup before release #513
- Updates the locations array with new locations list that are part of the global manifest.
- Adds a utility script to update the locations from the manifest automatically. Thanks to @andrewvc
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewvc
reviewed
Jun 2, 2022
* Update locs programatically * Improvements * Fix casing and spaces
vigneshshanmugam
commented
Jun 2, 2022
| set -ex | ||
| TARGET=src/dsl/locations.ts | ||
| echo '// DO NOT EDIT - UPDATE WITH `npm run build:locations`' > $TARGET | ||
| echo 'export const LocationsMap =' >> $TARGET |
There was a problem hiding this comment.
remove -n to avoid the errors.
the builtin echo in sh(1) does not accept the -n option
andrewvc
approved these changes
Jun 2, 2022
|
We have decided to leave it as it. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.