fix: add product scope to keygen provider #6975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9a7f5ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a product qualifier to artifact download requests. Resolving an issue where, in the case of a Keygen account distributing multiple products using electron-builder, a conflict can arise due to a shared filename across products. In most cases, this happens with
stable.ymland itsymlfriends.This issue will present itself under the following circumstances:
OPENdistribution strategy, meaning no license is required to view or download the artifacts. For example, Product A has aLICENSEDdistribution strategy, while Product B has anOPENdistribution strategy. This may result in Product A's updater requesting thelatest.ymlartifact without a product qualifier, causing our API to return the artifact of Product B, given it was released at a later date or has a higher version number.Both of these scenarios result in a failed update.