Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add product scope to Keygen publisher #6990

Conversation

ezekg
Copy link
Contributor

@ezekg ezekg commented Jul 6, 2022

Applying #6975 to the Keygen publisher as well. As covered in the linked PR, in the case of an OPEN product, the Keygen publisher's find-or-create method could receive a false positive if an open release is already available which has the same version as the one being created. This resolves the issue by adding a product qualifier to all release GET requests.

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2022

🦋 Changeset detected

Latest commit: 197c76f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 197c76f
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62c5fdc9d07b1f000835a72d
😎 Deploy Preview https://deploy-preview-6990--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ezekg ezekg marked this pull request as ready for review July 6, 2022 21:26
@mmaietta mmaietta merged commit c3407a2 into electron-userland:master Jul 7, 2022
@github-actions github-actions bot mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants