publisher-electron-release-server send "RELEASES" file and fail

[valentin-debris]

Preflight Checklist

• I agree to follow the code of conduct that this project follows, as appropriate.
• I have read the contribution documentation for this project.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

• Electron Forge Version:
  • 6.0.0-beta.52
• Electron Version:
  • 9.1.1
• Operating System:
  • Windows 10 (1903)
• Last Known Working Electron Forge version::
  • never used before

Expected Behavior

When publish to electron-release-server, only the .nupkg & .exe should be send (https://github.com/ArekSredzki/electron-release-server/blob/master/docs/assets.md#windows)

Actual Behavior

The publisher send all files under squirrel.windows folder, so 3 files :

• my-app-1.0.1 Setup.exe
• my_app-1.0.1-full.nupkg
• RELEASES

The last one is refused by the api that throw an error, that stop the upload

An unhandled error has occurred inside Forge:
ERS publish failed with status code: 400 (https://example.com/api/asset)
Error: ERS publish failed with status code: 400 (https://example.com/api/asset)

Maybe this is related to this pull request (#1538). For now, I can fix it by modifying the code in the server (return fake 200 if file == RELEASES), but I guess this should be fix in the module.

To Reproduce

Create a new project with "yarn create electron-app my-app" and try to publish.
I can send in private access to my Electron Release Server.

[Ririshi]

Having the same trouble. Downgraded my @electron-forge/publisher-electron-release-server to 6.0.0-beta.50 for now. The issue is that Forge is trying to upload the RELEASES file to ERS, which is explicitly not supposed to be uploaded, since the RELEASES file is always auto-generated by ERS when it receives a request.

An issue (ArekSredzki/electron-release-server#239) was also raised on the ERS side of things. I think the fix should be implemented on the Forge side of things, by removing RELEASES as an uploaded asset when using this publisher.

[gabrielmicko]

Hey, I can confirm this problem exists. I downgraded to .50 and I still have the same error.

[gabrielmicko]

Hey, I can confirm this problem exists. I downgraded to .50 and I still have the same error.

No, you are right "@electron-forge/publisher-electron-release-server": "6.0.0-beta.50" works.