Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher-electron-release-server): omit RELEASES file when uploading assets #2089

Conversation

monsterkrampe
Copy link
Contributor

closes: #1873

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
The RELEASES file is now filtered out from the artifacts and thus not send to electron release server.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2089 (45f523f) into master (286f96a) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
- Coverage   72.71%   72.64%   -0.07%     
==========================================
  Files          74       74              
  Lines        2221     2223       +2     
  Branches      420      420              
==========================================
  Hits         1615     1615              
- Misses        446      448       +2     
  Partials      160      160              
Impacted Files Coverage Δ
...lisher/electron-release-server/src/PublisherERS.ts 26.47% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286f96a...45f523f. Read the comment docs.

@monsterkrampe
Copy link
Contributor Author

As for #2088, I think that the coverage is not a real issue here.

@nullxx
Copy link

nullxx commented Apr 5, 2021

I am having the same issue. If this is not fixed, It will never work on Windows.

@monsterkrampe
Copy link
Contributor Author

monsterkrampe commented Apr 7, 2021

@nullxx If you need this fix right away, you can still try to use the modified version of the package within your project for example by putting it into a private NPM registry. This is also what I ended up doing for now since I do not know if and when this PR will be merged.

@nullxx
Copy link

nullxx commented Apr 7, 2021

I know, I made it, but with other approach. #2220

@monsterkrampe
Copy link
Contributor Author

monsterkrampe commented Apr 7, 2021

This also looks interesting.
We probably should discuss which solution to prefer. In particular, I would be interested what the repo owners think about that.
Being able to configure which files to publish certainly would not hurt anyway.

@malept could you give some feedback on any of the PRs regarding this issue? :)

@MarshallOfSound MarshallOfSound merged commit 2202dcd into electron:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publisher-electron-release-server send "RELEASES" file and fail
3 participants