S3 uploads are sometimes corrupted. (missing chunks)

[macdja38]

Pre-flight checklist

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project uses.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.0.4

Electron version

22.0.3

Operating system

macOS

Last known working Electron Forge version

No response

Expected behavior

S3 publish either fails with an error, or completes successfully.

Actual behavior

S3 publish looks like it has successfully completed, but in actuality one of the uploaded files is missing a 5MB chunk of data.

(the local data on disk is fine, but the uploaded copy is missing one or more 5MB chunks)

Steps to reproduce

Run the publish step on an un-reliable internet connection. (which to some degree is all internet connections, but it'll have to be particularly un-reliable to reproduce with any regularity)

Additional information

I've done some investigation into this.

It seems like the S3 publisher uses client-s3 to upload to S3 doesn't error when it fails to upload one or more parts of a larger file.

There's apparently an argument we can use (leavePartsOnError) that will cause it to either retry, or at the very least error if any part of the upload fails.

Significantly more info is available here: aws/aws-sdk-js-v3#2311