Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher-s3): Make S3 upload fail non-silently #3194

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

cpmsmith
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Fixes #3166

Simply put, the default behaviour of @aws-sdk/lib-storage is to fail silently if part of a file fails to upload to S3, but it includes this option, which makes it actually raise an error. There's a separate PR upstream (aws/aws-sdk-js-v3#4414) to make that behaviour the default.

See also: aws/aws-sdk-js-v3#2311

@cpmsmith cpmsmith requested a review from a team as a code owner March 24, 2023 22:40
@VerteDinde VerteDinde merged commit 0f73d64 into electron:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 uploads are sometimes corrupted. (missing chunks)
3 participants