Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): throw error if something bad happened in preload compilation #2334

Merged
merged 2 commits into from
Jul 11, 2021
Merged

fix(plugin-webpack): throw error if something bad happened in preload compilation #2334

merged 2 commits into from
Jul 11, 2021

Conversation

vhashimotoo
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Do the same as the renderer do, report and exit if all going bad

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2334 (17a7a4b) into master (7d46109) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
- Coverage   73.15%   72.38%   -0.78%     
==========================================
  Files          74       76       +2     
  Lines        2198     2285      +87     
  Branches      415      435      +20     
==========================================
+ Hits         1608     1654      +46     
- Misses        418      471      +53     
+ Partials      172      160      -12     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 33.51% <0.00%> (-24.96%) ⬇️
packages/utils/web-multi-logger/src/Log.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/utils/web-multi-logger/src/Logger.ts 21.05% <0.00%> (-68.43%) ⬇️
packages/utils/web-multi-logger/src/Tab.ts 20.00% <0.00%> (-60.00%) ⬇️
...es/plugin/webpack/src/util/ElectronForgeLogging.ts 13.79% <0.00%> (-48.28%) ⬇️
packages/plugin/webpack/src/WebpackConfig.ts 97.61% <0.00%> (ø)
packages/publisher/github/src/util/github.ts 100.00% <0.00%> (ø)
...lisher/electron-release-server/src/PublisherERS.ts 27.27% <0.00%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 78.26% <0.00%> (+0.98%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d46109...17a7a4b. Read the comment docs.

@malept malept merged commit 755a450 into electron:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants