Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): throw error if something bad happened in preload compilation #2334

Merged
merged 2 commits into from
Jul 11, 2021
Merged

fix(plugin-webpack): throw error if something bad happened in preload compilation #2334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8420c48
fix: throw error if something bad happened
vhashimotoo Jun 18, 2021
17a7a4b
fix(plugin-webpack): specify which entry point made the error
malept Jul 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/plugin/webpack/src/WebpackPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,13 @@ Your packaged app may be larger than expected if you dont ignore everything othe
for (const entryPoint of this.config.renderer.entryPoints) {
if (entryPoint.preload) {
await asyncOra(`Compiling Renderer Preload: ${entryPoint.name}`, async () => {
await this.runWebpack(
const stats = await this.runWebpack(
await this.configGenerator.getPreloadRendererConfig(entryPoint, entryPoint.preload!),
);

if (stats?.hasErrors()) {
throw new Error(`Compilation errors in the preload (${entryPoint.name}): ${stats.toString()}`);
}
});
}
}
Expand Down