Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): fix deprecation warnings for dev-server@4.0.0 #2457

Merged
merged 5 commits into from
Aug 19, 2021

Conversation

malept
Copy link
Member

@malept malept commented Aug 19, 2021

Summarize your changes:

It looks like between webpack-dev-server 4.0.0-rc.0 and 4.0.0, they added some API deprecations/breakage. This updates all that based on the migration docs.

Fixes #2456

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #2457 (522ccdf) into master (bd2526b) will increase coverage by 2.34%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2457      +/-   ##
==========================================
+ Coverage   73.00%   75.35%   +2.34%     
==========================================
  Files          91       91              
  Lines        2349     2353       +4     
  Branches      440      440              
==========================================
+ Hits         1715     1773      +58     
- Misses        469      472       +3     
+ Partials      165      108      -57     
Impacted Files Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts 36.84% <0.00%> (ø)
packages/maker/base/src/Maker.ts 75.67% <0.00%> (-2.11%) ⬇️
packages/installer/darwin/src/InstallerDarwin.ts 31.57% <0.00%> (-1.76%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 94.73% <0.00%> (-1.70%) ⬇️
packages/api/core/src/api/init.ts 97.56% <0.00%> (+4.87%) ⬆️
packages/api/core/src/api/make.ts 88.29% <0.00%> (+6.57%) ⬆️
packages/api/core/src/util/rebuild.ts 100.00% <0.00%> (+7.14%) ⬆️
packages/api/core/src/api/install.ts 94.87% <0.00%> (+16.66%) ⬆️
packages/api/core/src/api/start.ts 87.65% <0.00%> (+22.22%) ⬆️
packages/api/core/src/api/publish.ts 92.10% <0.00%> (+22.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2526b...522ccdf. Read the comment docs.

@malept malept merged commit 9979744 into master Aug 19, 2021
@malept malept deleted the malept/fix/plugin-webpack/dev-server-deprecations branch August 19, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while closing application with webpack template
2 participants