Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): fix deprecation warnings for dev-server@4.0.0 #2457

Merged
merged 5 commits into from
Aug 19, 2021
Merged

fix(plugin-webpack): fix deprecation warnings for dev-server@4.0.0 #2457

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
efa4739
fix(plugin-webpack): fix deprecation warnings for dev-server@4.0.0
malept Aug 19, 2021
4177f4d
start doesn't take a port
malept Aug 19, 2021
aaeb508
Deprecation warning changes require ^4.0.0
malept Aug 19, 2021
c0fcb37
Fix manual typings
malept Aug 19, 2021
522ccdf
Fix typo
malept Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions typings/webpack-dev-server/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ declare module 'webpack-dev-server' {
import { Server } from 'http';
import { Compiler } from 'webpack';
class WebpackDevServer {
constructor(compiler: Compiler, options?: {})
listen(port?: number, hostname?: string): Promise<Server>
constructor(options: {}, compilter: Compiler)
malept marked this conversation as resolved.
Show resolved Hide resolved
server: Server;
start(): Promise<void>
close(): void
}
export default WebpackDevServer;
Expand Down