Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publisher): remove deprecated option from @octokit/rest params #504

Merged
merged 1 commit into from
May 6, 2018
Merged

fix(publisher): remove deprecated option from @octokit/rest params #504

merged 1 commit into from
May 6, 2018

Conversation

malept
Copy link
Member

@malept malept commented May 4, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This broke with @octokit/rest.js 15.2.0.
Fixes #493.

@malept malept requested a review from MarshallOfSound May 4, 2018 05:01
@malept
Copy link
Member Author

malept commented May 4, 2018

Ah crap, there are actually tests for this 😆

@malept
fix(publisher): remove deprecated option from @octokit/rest params
e3da8c0 
This broke with @octokit/rest.js 15.2.0

ISSUES CLOSED: #493
@malept malept force-pushed the remove-deprecated-github-options-5.x branch from 0af3e86 to e3da8c0 Compare May 4, 2018 05:08
@malept
Copy link
Member Author

malept commented May 4, 2018

Fixed the tests, doing the 6.x fix now as well.

@malept
Copy link
Member Author

malept commented May 4, 2018

The CI is being super weird and I don't know why 😢

@MarshallOfSound
Copy link
Member

Will rerun tomorrow when babel hopefully realizes this is broken and fixes it lol

@malept malept merged commit 15a6879 into 5.x May 6, 2018
@malept malept deleted the remove-deprecated-github-options-5.x branch May 6, 2018 23:23
@maniator maniator mentioned this pull request Jan 9, 2023
Open
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@felixrieseberg
Merge pull request #504 from electron/gh-build
6a7decd 
build: Use GitHub Actions to build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malept @MarshallOfSound