Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): stops breaking regexps in the config parser #566

Merged
merged 2 commits into from
Sep 7, 2018
Merged

fix(core): stops breaking regexps in the config parser #566

merged 2 commits into from
Sep 7, 2018

Conversation

MarshallOfSound
Copy link
Member

Fixes #557

Basically typeof /foo/ === 'object'

@malept malept self-requested a review September 7, 2018 15:29
malept
malept approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are fine, it's the same error as #558 (comment)

@malept malept merged commit d2ef60b into master Sep 7, 2018
@malept malept deleted the conf-regexps branch September 7, 2018 16:54
@maniator maniator mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @malept