-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(maker-wix): correct path to distributable #609
Conversation
Good catch 🙇 |
Hmmm. Shouldn't the maker specs test that the output file paths returned exist? |
@malept In this case the tests were passing because the file returned from the maker |
Can we get this merged? The 2 failing test cases are also affecting my completely unrelated changes in #623, which makes me think they are also unrelated to these changes. |
I'd like it if the test that was mentioned in the comments here were addressed before we merge, to avoid problems like this in the future. |
I think I've written a regression test for this (2392832) but the tests are failing due to failures that are also in master. |
* fix: accidental switch fall-through in remote-loader * chore: undo unnecessary change
Summarize your changes:
Fixes #608.