Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a hook before MSICreator.create() is called #623

Merged
merged 2 commits into from
Nov 17, 2018

Conversation

mako-taco
Copy link

@mako-taco mako-taco commented Nov 9, 2018

This allows users to take advantage of the template configuration that electron-wix-msi provdes (see https://github.com/felixrieseberg/electron-wix-msi#template-configuration-optional for details)

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@mako-taco
Copy link
Author

It doesn't appear like there are any tests for MakerWix.ts right now, unless I'm missing something?

@mako-taco mako-taco force-pushed the master branch 3 times, most recently from 3b079ca to a0cebda Compare November 9, 2018 02:31
@malept
Copy link
Member

malept commented Nov 9, 2018

It doesn't appear like there are any tests for MakerWix.ts right now, unless I'm missing something?

There aren't, but that doesn't mean you can't add them. What would tests look like without running the WiX maker? (Because that already takes a really long time, and the testsuite takes a while to run as it is.)

@mako-taco
Copy link
Author

It doesn't appear like there are any tests for MakerWix.ts right now, unless I'm missing something?

There aren't, but that doesn't mean you can't add them. What would tests look like without running the WiX maker? (Because that already takes a really long time, and the testsuite takes a while to run as it is.)

We can optionally pass a function which returns an MSICreator to make (defaulting to (config) => new MSICreator(config)), then mock that in tests, and assert that beforeCreate is called. sound good?

@mako-taco mako-taco force-pushed the master branch 3 times, most recently from 261db10 to 6c3a83c Compare November 17, 2018 00:36
This allows users to take advantage of the template configuration that electron-wix-msi provdes (see https://github.com/felixrieseberg/electron-wix-msi#template-configuration-optional for details)

trailing whitespace removal
@MarshallOfSound MarshallOfSound changed the title Adds a hook before MSICreator.create() is called feat: adds a hook before MSICreator.create() is called Nov 17, 2018
@MarshallOfSound MarshallOfSound merged commit 9adca97 into electron:master Nov 17, 2018
@whysofunky
Copy link

Do you have an estimate of when this change will be published?

@MarshallOfSound
Copy link
Member

@whysofunky v6.0.0-beta.30 went out today 👍

dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
* chore: no-unused-imports

* chore: no-unused-imports (components)

* chore: remove unused getRandomNumber()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants