-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds a hook before MSICreator.create() is called #623
Conversation
It doesn't appear like there are any tests for |
3b079ca
to
a0cebda
Compare
There aren't, but that doesn't mean you can't add them. What would tests look like without running the WiX maker? (Because that already takes a really long time, and the testsuite takes a while to run as it is.) |
We can optionally pass a function which returns an |
261db10
to
6c3a83c
Compare
This allows users to take advantage of the template configuration that electron-wix-msi provdes (see https://github.com/felixrieseberg/electron-wix-msi#template-configuration-optional for details) trailing whitespace removal
Do you have an estimate of when this change will be published? |
@whysofunky |
* chore: no-unused-imports * chore: no-unused-imports (components) * chore: remove unused getRandomNumber()
This allows users to take advantage of the template configuration that electron-wix-msi provdes (see https://github.com/felixrieseberg/electron-wix-msi#template-configuration-optional for details)
Summarize your changes: