-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Various improvements for electron/template #950
Conversation
.webpack/ | ||
|
||
# Electron-Forge | ||
out/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the Node.gitignore
...
🤔 it'd be interesting if this were automatically updated with a GitHub Action...
* [Webpack Documentation](https://webpack.js.org/) | ||
* [Node.js Documentation](https://nodejs.org/en/docs/) | ||
|
||
[generate]: https://github.com/electron/template/generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether this fits in the Webpack template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just keep this in electron/template
only for now.
padding: 2rem; | ||
margin: auto; | ||
} | ||
</style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should go in a separate CSS file, mostly to show that non-transpiled files work fine with Forge+Webpack. There was a question about it in the issue tracker the other day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sure - I'd say let's incrementally improve this as much as there's time and appetite! If you think this is better than what's there right now, let's go with this first - I'm just trying to get electron/template
🚢
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Summarize your changes:
.gitignore
file to cover most common Node.js tools, ensuring that nobody gets caught by surprise check-in filesREADME
for the webpack template. It's currently the same as forelectron/template
, but maybe that's okay?renderer.js
a little bit, explaining what's what