-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Various improvements for electron/template #950
Changes from all commits
8c49e38
76be728
5c68638
82011ff
756a209
184c08d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,89 @@ | ||
node_modules | ||
out | ||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
lerna-debug.log* | ||
|
||
# Diagnostic reports (https://nodejs.org/api/report.html) | ||
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json | ||
|
||
# Runtime data | ||
pids | ||
*.pid | ||
*.seed | ||
*.pid.lock | ||
.DS_Store | ||
|
||
# Directory for instrumented libs generated by jscoverage/JSCover | ||
lib-cov | ||
|
||
# Coverage directory used by tools like istanbul | ||
coverage | ||
*.lcov | ||
|
||
# nyc test coverage | ||
.nyc_output | ||
|
||
# node-waf configuration | ||
.lock-wscript | ||
|
||
# Compiled binary addons (https://nodejs.org/api/addons.html) | ||
build/Release | ||
|
||
# Dependency directories | ||
node_modules/ | ||
jspm_packages/ | ||
|
||
# TypeScript v1 declaration files | ||
typings/ | ||
|
||
# TypeScript cache | ||
*.tsbuildinfo | ||
|
||
# Optional npm cache directory | ||
.npm | ||
|
||
# Optional eslint cache | ||
.eslintcache | ||
|
||
# Optional REPL history | ||
.node_repl_history | ||
|
||
# Output of 'npm pack' | ||
*.tgz | ||
|
||
# Yarn Integrity file | ||
.yarn-integrity | ||
|
||
# dotenv environment variables file | ||
.env | ||
.env.test | ||
|
||
# parcel-bundler cache (https://parceljs.org/) | ||
.cache | ||
|
||
# next.js build output | ||
.next | ||
|
||
# nuxt.js build output | ||
.nuxt | ||
|
||
# vuepress build output | ||
.vuepress/dist | ||
|
||
# Serverless directories | ||
.serverless/ | ||
|
||
# FuseBox cache | ||
.fusebox/ | ||
|
||
# DynamoDB Local files | ||
.dynamodb/ | ||
|
||
# Webpack | ||
.webpack/ | ||
|
||
# Electron-Forge | ||
out/ | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,19 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<meta charset="utf-8"> | ||
<title></title> | ||
<meta charset="UTF-8"> | ||
<title>Hello World!</title> | ||
<style> | ||
body { | ||
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif; | ||
max-width: 38rem; | ||
padding: 2rem; | ||
margin: auto; | ||
} | ||
</style> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if this should go in a separate CSS file, mostly to show that non-transpiled files work fine with Forge+Webpack. There was a question about it in the issue tracker the other day. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, sure - I'd say let's incrementally improve this as much as there's time and appetite! If you think this is better than what's there right now, let's go with this first - I'm just trying to get |
||
</head> | ||
<body> | ||
Well hey there!!! | ||
<h1>💖 Hello World!</h1>3 | ||
<p>Welcome to your Electron application.</p> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,29 @@ | ||
console.log('Heya, this is coming from a webpack bundle'); | ||
/** | ||
* This file will automatically be loaded by webpack and run in the "renderer" context. | ||
* To learn more about the differences between the "main" and the "renderer" context in | ||
* Electron, visit: | ||
* | ||
* https://electronjs.org/docs/tutorial/application-architecture#main-and-renderer-processes | ||
* | ||
* By default, Node.js integration in this file is disabled. When enabling Node.js integration | ||
* in a renderer process, please be aware of potential security implications. You can read | ||
* more about security risks here: | ||
* | ||
* https://electronjs.org/docs/tutorial/security | ||
* | ||
* To enable Node.js integration in this file, open up `main.js` and enable the `nodeIntegration` | ||
* flag: | ||
* | ||
* ``` | ||
* // Create the browser window. | ||
* mainWindow = new BrowserWindow({ | ||
* width: 800, | ||
* height: 600, | ||
* webPreferences: { | ||
* nodeIntegration: true | ||
* } | ||
* }); | ||
* ``` | ||
*/ | ||
|
||
console.log(`👋 This message is being logged by "renderer.js", included via webpack`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the
Node.gitignore
...🤔 it'd be interesting if this were automatically updated with a GitHub Action...