Différentes corrections de bug liées aux créneaux #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
petitalb
commented
Nov 1, 2022
petitalb
commented
- Fix booker attribute in shift (and remove unnecessary code)
- Allow account with non beneficiaries to book period shift
- Allow to impersonate user without beneficiary
raphodn
approved these changes
Nov 2, 2022
| @@ -37,4 +37,19 @@ public function findNonMember() | |||
|
|
|||
| return $qb->getQuery()->getResult(); | |||
| } | |||
|
|
|||
| public function findSuperAdminAccount() | |||
There was a problem hiding this comment.
il ne peut y avoir qu'un seul SUPER_ADMIN ?
There was a problem hiding this comment.
Non mais j'en ai besoin que d'un seul, je considère que le 1er compte SUPER_ADMIN c'est un compte robot. Après on pourrait mettre à null ? Mais je trouvais plus jolie de mettre que c'est babar qui a fait la réservation plutôt que null :)
There was a problem hiding this comment.
Et une fois en prod on arriverait à remplir l'historique ? 😉
| @@ -56,6 +56,7 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $em = $this->getContainer()->get('doctrine')->getManager(); | |||
| $mailer = $this->getContainer()->get('mailer'); | |||
| $periodRepository = $em->getRepository('AppBundle:Period'); | |||
| $admin = $em->getRepository('AppBundle:User')->findSuperAdminAccount(); | |||
raphodn
reviewed
Nov 4, 2022
| @@ -77,7 +77,7 @@ class Shift | |||
| private $shifter; | |||
|
|
|||
| /** | |||
| * @ORM\ManyToOne(targetEntity="Beneficiary", inversedBy="booked_shifts") | |||
| * @ORM\ManyToOne(targetEntity="User") | |||
There was a problem hiding this comment.
après discussion, la question se pose de la différence entre User et Beneficiary...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.