Feature/unwedging #1261
Merged
Feature/unwedging #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
Apr 22, 2020
| // return | ||
| // } | ||
| // | ||
| // val lastForcedDate = lastNewSessionForcedDates.getObject(senderId, deviceKey) ?: 0 |
There was a problem hiding this comment.
the date management is not used anymore then?
There was a problem hiding this comment.
good catch, didn't know it was implemented
| @@ -111,6 +111,8 @@ interface CryptoService { | |||
| roomId: String, | |||
| callback: MatrixCallback<MXEncryptEventContentResult>) | |||
|
|
|||
| fun discardOutbundSession(roomId: String) | |||
| @@ -58,6 +59,8 @@ class CommonTestHelper(context: Context) { | |||
| val matrix: Matrix | |||
|
|
|||
| init { | |||
| Timber.plant(Timber.DebugTree()) | |||
BillCarsonFr
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MSC1719
I'm a bit stuck now. The test is passing, but
When I implementing it a month ago, the test
testUnwedging()was:but now (after rebasing the branch), it is passing, even with 5900245
The last commit (a6368c4) contains the implementation, and the test is passing too, but we do not send any
m.dummymessage,markOlmSessionForUnwedging()is never called.I think a fresh look on the code will be help full.
@BillCarsonFr could you help please?