Switch to new group call if the call in a room changes #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR comes with a lot of caveats currently: * It removes the leaveCall() from when the useGroupCall() hook is torn down. I can't see another way of maintaining the correct joined state (because switching group calls will cause the effects to re-run) but this does mean that if the user somehow navigates within the app without using the hangup button, they won't leave the call. * The state of the call will be reset on switch, including the state of the screenshare, what devices are being used and even the mute states. Unsure if it's better to try & fix these up by moving state around or whether to refactor more in js-sdk so the group call can be switched more transparently.
|
Superseded by #1348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with a lot of caveats currently:
Unsure if it's better to try & fix these up by moving state around or whether to refactor more in js-sdk so the group call can be switched more transparently.
Requires: matrix-org/matrix-js-sdk#3636