Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new group call if the call in a room changes #1314

Closed
wants to merge 1 commit into from

Commits on Jul 28, 2023

  1. Switch to new group call if the call in a room changes

    This PR comes with a lot of caveats currently:
     * It removes the leaveCall() from when the useGroupCall() hook is
       torn down. I can't see another way of maintaining the correct
       joined state (because switching group calls will cause the effects
       to re-run) but this does mean that if the user somehow navigates
       within the app without using the hangup button, they won't leave
       the call.
     * The state of the call will be reset on switch, including the state
       of the screenshare, what devices are being used and even the mute
       states.
    
    Unsure if it's better to try & fix these up by moving state around or
    whether to refactor more in js-sdk so the group call can be switched
    more transparently.
    dbkr committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1c7a555 View commit details
    Browse the repository at this point in the history