Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if incompatible versions are being used #391

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jun 9, 2022

This will probably be overly sensitive until we start timing out
member events (ie. matrix-org/matrix-js-sdk#2446
lands) because lots of calls might have old member events from people
who've joined previously.

Screenshot 2022-06-09 at 21 55 11

Requires matrix-org/matrix-js-sdk#2447
Fixes #383

This will probably be overly sensitive until we start timing out
member events (ie. matrix-org/matrix-js-sdk#2446
lands) because lots of calls might have old member events from people
who've joined previously.
@dbkr dbkr requested a review from a team as a code owner June 9, 2022 21:04
src/IncompatibleVersionModal.tsx Outdated Show resolved Hide resolved
src/index.css Outdated Show resolved Hide resolved
src/Header.jsx Show resolved Hide resolved
src/button/Button.module.css Outdated Show resolved Hide resolved
@dbkr dbkr changed the title Add warning if incompatible versionsd are being used Add warning if incompatible versions are being used Jun 10, 2022
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dbkr dbkr merged commit 3755781 into main Jun 10, 2022
@dbkr dbkr deleted the dbkr/version_warning branch December 21, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video room connects for some users but not others
2 participants