Add a 'waiting for video' state to media tiles #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will show if the call is waiting for media to connect (in practice doesn't actually seem to happen all that often) but also show if the media connection is lost, with the js-sdk change. Requires matrix-org/matrix-js-sdk#2880 Fixes: #669
dbkr
added
the
T-Enhancement
src/room/InCallView.tsx
Outdated
| @@ -231,11 +292,19 @@ export function InCallView({ | |||
| focused: true, | |||
| isLocal: screenshareFeed.isLocal(), | |||
| presenter: false, | |||
| connectionState: ConnectionState.CONNECTED, // by definition since the screen shares arrived on the same connection | |||
There was a problem hiding this comment.
What if the connection dropped later?
There was a problem hiding this comment.
True - have passed through the connection state of the relevant user (although we don't display it for screenshares anyway).
Co-authored-by: Robin <robin@robin.town>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show if the call is waiting for media to connect (in practice doesn't actually seem to happen all that often) but also show if the media connection is lost, with the js-sdk change.
Requires matrix-org/matrix-js-sdk#2880
Fixes: #669