Handle terms agreement in the Discovery section of settings

[jryans]

It's possible that the Discovery section of settings is the first place the user interacts with their identity server, and therefore we need to show some kind of state when terms haven't been agreed yet, allow for agreeing the terms, etc.

Maybe something like "⚠️ You need to agree to Identity Server terms before you can share your email addresses and phone numbers. " inline in the Discovery section?

[nadonomy]

@jryans yep this sounds totally reasonable!

Looking at the design, I think the best thing to do would be to hide all of the Discovery section content and display this warning in place, as I think it'll just provide more noise than value if we expose it in a disabled/low alpha state.

Does that sound good to you? If so let me know and I can update Sketch/Zeplin with the warning.

[jryans]

Yes, I think that sounds reasonable for the issue described here. I recently also raised #10525, which makes me concerned that other steps (like adding a 3PID to your account in General settings) may also face this issue.

In any case @nadonomy, we can probably apply the same UX to any other areas facing this as well, so updating designs as you described sounds good to me.

[nadonomy]

Ok, in that case I'll add a comp for how we can visualise this generically in any section in Settings.

[jryans]

Marking blocked for now until we have designs.

[nadonomy]

@jryans I've updated Zeplin here: https://zpl.io/brMdWo3

I'm a little removed from the privacy project while I'm working on other things, so would appreciate any input/to rubber duck any logical dependencies or if you think we should/shouldn't expose changing an identity server in this state, etc.

But, hopefully this is enough to unblock the visual design at least, even if we need to chew the fat on some of the minutiae of what we do/don't expose.

[jryans]

Thanks, I think that's seems like it should work to me. 😁