This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Handle terms agreement in Discovery section of user settings #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we can optionally do our own terms handling.
Handles agreement of terms in an inline way.
It really wants a trailing comma.
dbkr
reviewed
Aug 21, 2019
src/components/views/settings/tabs/user/GeneralUserSettingsTab.js
Outdated
Show resolved
Hide resolved
dbkr
approved these changes
Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10522
Reviewer: it may be easier to go commit-by-commit here.