Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nag UI when some of your own devices are not verified by you #11220

Closed
dbkr opened this issue Oct 24, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3940
Closed

Nag UI when some of your own devices are not verified by you #11220

dbkr opened this issue Oct 24, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3940
Assignees
Labels
A-E2EE-Cross-Signing X-Needs-Product More input needed from the Product team

Comments

@dbkr
Copy link
Member

dbkr commented Oct 24, 2019

  • If cross-signing labs flag enabled, whenever we have devices (in e2e, not the devices endpoint, ie. ignoring devices that don't support e2e at all) that are not marked as verified, show the nag bar new sign in toast.

Q: Does this also apply if the device itself is not verified? Or should that be a different thing?
A: This is the 'Skipped Verify' toast: https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=38%3A16

@jryans
Copy link
Collaborator

jryans commented Jan 3, 2020

The current thinking now is that this will be the same "new sign-in" toast as #11218, but potentially saying "unverified" instead of "new" for devices aren't actually new.

@lampholder lampholder changed the title Untrusted devices nag UI Nag UI when some of your own devices are not verified by you Jan 9, 2020
@lampholder lampholder added the X-Needs-Product More input needed from the Product team label Jan 9, 2020
@lampholder
Copy link
Member

Is a toast right to represent this? It's not a real-time event, and you device will still be unverified if you dismiss the toast.

If we do want a toast:

  • when does it appear
  • when does it return if you dismiss it
  • can you dismiss it 'permanently' (and how is permanently defined)

@jryans
Copy link
Collaborator

jryans commented Jan 20, 2020

Let's ping @nadonomy for thoughts here. At the moment, the current implementation shows "new session" toats for both real time new sessions as well as all pre-existing unverified sessions, so existing users can be slapped by a large stack of toasts to work through.

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 25, 2020
Implement the three differenty cases for this session, and also fix
ones for other sessions which had the wrong copy.

Fixes element-hq/element-web#11220
@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing X-Needs-Product More input needed from the Product team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants