This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Verification nag toasts #3940
Merged
Verification nag toasts #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the three differenty cases for this session, and also fix ones for other sessions which had the wrong copy. Fixes element-hq/element-web#11220
jryans
approved these changes
Jan 25, 2020
| // No cross-signing on account but key backup available (upgrade encryption) | ||
| ToastStore.sharedInstance().addOrReplaceToast({ | ||
| key: THIS_DEVICE_TOAST_KEY, | ||
| title: _t("Encryption upgrade available"), |
There was a problem hiding this comment.
It's a bit hard to check everything for consistency when the toast titles are written separately from the description and buttons that they go with. Not something that has to be changed now, but just pointing out it would easier to review if all of content for a given toast was in the same place.
There was a problem hiding this comment.
Yeah, agreed this is a bit odd, although arguably I should have fixed it when we only had one toast to fix!
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
dbkr
commented
Jan 27, 2020
This was referenced Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the three differenty cases for this session, and also fix
ones for other sessions which had the wrong copy.
Fixes element-hq/element-web#11220