Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joined room shows preview instead of timeline #21661

Closed
kittykat opened this issue Apr 4, 2022 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2277
Closed

Joined room shows preview instead of timeline #21661

kittykat opened this issue Apr 4, 2022 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2277
Assignees
@robintown
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@kittykat
Copy link
Contributor

kittykat commented Apr 4, 2022 •
edited
Loading

Steps to reproduce

  1. Create a private and encrypted room
  2. Send a message to it
  3. Open develop in a new tab

Outcome

What did you expect?

See room

What happened instead?

See "Room can't be previewed. Do you want to join it? Join the discussion" message for !fLucxucySnKHAzddGa:matrix.org

Screenshot from 2022-04-04 12-06-44

Clicking on "Join the discussion" doesn't load the timeline, but gets stuck with an infinispinner.

Browser information

Chromium 98.0.4758.102 (Official Build) Arch Linux (64-bit)

URL for webapp

develop.element.io

Application version

Element version: b1a60b2-react-13a51654e782-js-71b7521f4223 Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

Yes
@kittykat
Copy link
Contributor Author

kittykat commented Apr 4, 2022

I can also reproduce this in !YgGhYUhqaotdNCnTKf:matrix.org with Element version: 1.10.8; Olm version: 3.2.8

@dbkr dbkr added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 5, 2022
@dbkr
Copy link
Member

dbkr commented Apr 5, 2022

Have given this o-uncommon - re-label if we see more reports.

@robintown
Copy link
Member

I can reproduce this consistently, bumping to o-occasional

@robintown robintown added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 6, 2022
@robintown robintown self-assigned this Apr 6, 2022
@robintown robintown mentioned this issue Apr 6, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Apr 30, 2022
@su-ex
Merge tag 'v17.1.0' into sc
c696abf 
* Add MatrixClient.doesServerSupportLogoutDevices() for MSC2457 ([\matrix-org#2297](matrix-org#2297)).
* Live location sharing - expose room liveBeaconIds ([\matrix-org#2296](matrix-org#2296)).
* Support for MSC2457 logout_devices param for setPassword() ([\matrix-org#2285](matrix-org#2285)).
* Stabilise token authenticated registration support ([\matrix-org#2181](matrix-org#2181)). Contributed by @govynnus.
* Live location sharing - Aggregate beacon locations on beacons ([\matrix-org#2268](matrix-org#2268)).
* Prevent duplicated re-emitter setups in event-mapper ([\matrix-org#2293](matrix-org#2293)).
* Make self membership less prone to races ([\matrix-org#2277](matrix-org#2277)). Fixes element-hq/element-web#21661.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robintown robintown

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make self membership less prone to races robintown/matrix-js-sdk
3 participants
@kittykat @dbkr @robintown