Support for MSC2457 logout_devices param for setPassword() #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2285 +/- ##
===========================================
- Coverage 59.39% 59.38% -0.02%
===========================================
Files 91 91
Lines 16360 16364 +4
Branches 3771 3773 +2
===========================================
Hits 9717 9717
- Misses 6643 6647 +4
|
t3chguy
requested changes
Apr 8, 2022
t3chguy
approved these changes
Apr 8, 2022
|
Optional: could we get test coverage over the backwards compatible signature? |
|
@t3chguy i added tests trying to follow existing patterns. In doing so I noted that it would be better to make the default behaviour actually mimic the current behaviour. Specifically making it so that if the existing setPassword signature is used then the |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Apr 30, 2022
* Add MatrixClient.doesServerSupportLogoutDevices() for MSC2457 ([\matrix-org#2297](matrix-org#2297)). * Live location sharing - expose room liveBeaconIds ([\matrix-org#2296](matrix-org#2296)). * Support for MSC2457 logout_devices param for setPassword() ([\matrix-org#2285](matrix-org#2285)). * Stabilise token authenticated registration support ([\matrix-org#2181](matrix-org#2181)). Contributed by @govynnus. * Live location sharing - Aggregate beacon locations on beacons ([\matrix-org#2268](matrix-org#2268)). * Prevent duplicated re-emitter setups in event-mapper ([\matrix-org#2293](matrix-org#2293)). * Make self membership less prone to races ([\matrix-org#2277](matrix-org#2277)). Fixes element-hq/element-web#21661.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what your changelog entry will look like:
✨ Features