Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies look like notices/are greyed out #25788

Closed
turt2live opened this issue Jul 13, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11273
Closed

Replies look like notices/are greyed out #25788

turt2live opened this issue Jul 13, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11273
Assignees
@germain-gg
Labels
A11y A-Replies reply O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Replicate the screenshot

Outcome

What did you expect?

Previous styling which represented the sender's replying text as high contrast, as though it was a regular message.

What happened instead?

image

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023071301 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No
@t3chguy
Copy link
Member

t3chguy commented Jul 13, 2023 •
edited
Loading

image

This is a WCAG AA/AAA fail

Compared to staging

image

@t3chguy t3chguy added X-Regression X-Release-Blocker A-Replies reply A11y S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 13, 2023
@robintown
Copy link
Member

I believe the trigger for this is the message being highlighted (doesn't have to be a reply)

@germain-gg germain-gg self-assigned this Jul 13, 2023
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2023
Restore alert color for highlighted events
d56552b 
Fixes element-hq/element-web#25788
@germain-gg germain-gg mentioned this issue Jul 17, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2023
Fix colour regressions (#11273)
5d4153f 
* Fix color contrast of notice events

Fixes element-hq/element-web#25808

* Restore alert color for highlighted events

Fixes element-hq/element-web#25788

* Fix quote border for highlighted events

Fixes element-hq/element-web#25811

* Fix media background mixing with event highlighted

Fixes element-hq/element-web#25812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A11y A-Replies reply O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix colour regressions matrix-org/matrix-react-sdk
4 participants
@germain-gg @turt2live @t3chguy @robintown